Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xml parser: fix a regression in 40082dcf/b3874805 #602

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

bbshelper
Copy link
Contributor

@bbshelper bbshelper commented Sep 1, 2024

Wrongly calculated limit could be smaller than ptr, causing infinite loop.


This change is Reviewable

@poire-z
Copy link
Contributor

poire-z commented Sep 1, 2024

You mention 2 commit hashes, one is 40082dc, but I can't find the other: c7738720

@bbshelper bbshelper changed the title xml parser: fix a regression in 40082dcf/c7738720 xml parser: fix a regression in 40082dcf/b3874805 Sep 2, 2024
@bbshelper
Copy link
Contributor Author

It should be b387480. I've changed the title.

Wrongly calculated `limit` could be smaller than `ptr`, causing
infinite loop.
@poire-z poire-z merged commit 6e6a993 into koreader:master Sep 2, 2024
1 check passed
@poire-z
Copy link
Contributor

poire-z commented Sep 2, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants